Rebase Vite/Vitest tooling onto our stack (keep MAX_BUFFER_SIZE fix)#89
Open
OBrezhniev wants to merge 3 commits into
Open
Rebase Vite/Vitest tooling onto our stack (keep MAX_BUFFER_SIZE fix)#89OBrezhniev wants to merge 3 commits into
OBrezhniev wants to merge 3 commits into
Conversation
Rollup -> Vite (node build/main.cjs + new browser ESM build), Mocha -> Vitest with node + browser (Playwright) projects, flat eslint.config.js, CI workflow. Adds the first real test coverage (node + browser round-trip). Keeps OUR src/binfileutils.js (the MAX_BUFFER_SIZE 1 GiB constant — their branch reintroduces the buggy Buffer.constants probe we fixed) and our git+https pins. node + browser tests pass; CJS require + browser ESM verified.
Member
Author
|
ESM-rebase set — the tooling migration re-applied on top of our optimization stack (rather than replaying the branches), so the MSM/CIOS/memory work is preserved. Review together:
Deviations from feat/esm-migration are called out in each PR body (e.g. binfileutils MAX_BUFFER_SIZE, snarkjs IIFE/bfj, mnt6753 excluded, smart_contracts test deferred). All branches keep git+https commit-ref pins; re-pin if a branch moves. |
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase tooling migration onto our stack (Vite + Vitest)
Applies
feat/esm-migrationtooling on top of ourfeature/sharedArrayBufferswork. Target:
feat/esm-migration.build/main.cjs+ browser ESM), Mocha → Vitest withnode + browser (Playwright) projects, flat
eslint.config.js, CI.src/binfileutils.js: theMAX_BUFFER_SIZE = 1 GiBconstant.feat/esm-migrationreintroduced theBuffer.constants.MAX_LENGTHprobe,which is always
undefined(those constants live on thebuffermodule, notthe
Bufferclass) — the bug we fixed. Please take this version.Validation: lint clean, node + browser round-trip tests pass.