BigBuffer paging threshold, dependency updates, commit-ref pins#88
Open
OBrezhniev wants to merge 11 commits into
Open
BigBuffer paging threshold, dependency updates, commit-ref pins#88OBrezhniev wants to merge 11 commits into
OBrezhniev wants to merge 11 commits into
Conversation
… it and use max available buffer size to minimize amount of work downstream switching between them. Debug logs.
MAX_BUFFER_SIZE gated on `Buffer.constants.MAX_LENGTH`, but those constants live on the `buffer` module, not the `Buffer` class, so the probe was always undefined and fell back to `1 << 30`. Drop the dead check and set 1 GiB explicitly, matched to BigBuffer's page size: sections at/above it are read into a paged BigBuffer instead of one flat Uint8Array. No behaviour change (the runtime value was already 1 GiB). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Migrates .eslintrc.cjs to flat eslint.config.mjs.
The committed manifest now resolves standalone (once the referenced branches are pushed). For local development keep uncommitted file:../ overrides in the working tree; the lockfile still records the local layout and gets regenerated after the branches are published.
console.time printed one line per section read into every consumer's output.
git+https installs anonymously (git+ssh needs SSH credentials).
Member
Author
|
PR stack (landing order):
Cross-repo deps are pinned by git+https commit refs; re-pin consumers if a branch gains commits before merge. |
This was referenced Jul 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigBuffer paging threshold, dependency updates, commit-ref pins
Summary
Companion to the snarkjs
feature/memory-scopingPR (which pins this branchby commit ref). Small net diff:
MAX_BUFFER_SIZEconstant — the 1 GiB BigBuffer paging threshold inreadSectionis now a named constant with a comment (matched toBigBuffer's page size) instead of an inline literal.
.eslintrc.cjsmigrated to flat
eslint.config.mjs); bundle rebuilt.fastfileandffjavascriptare pinned asgit+https://…#<commit>refs so the manifest resolves standalone;local development uses uncommitted
file:../overrides. Lockfileregenerated against the pins (verified:
npm ciworks with SSH disabled —exact-SHA GitHub deps fetch via the HTTPS codeload tarball).
An unfinished
readSectionToStreamhelper (referenced a never-declaredvariable; no callers) was completed and parked on
feature/read-section-to-stream— intentionally not part of this PR.Landing order
After the fastfile (
feature/direct_rw_optimization) and ffjavascript(
feature/msm-signed-buckets) branches land; alternatively re-point the twopins at published versions at merge time.
🤖 Generated with Claude Code