[codex] Add lint and typecheck gates#13
Merged
Merged
Conversation
Introduce Ruff linting and source-level mypy checking to the PR workflow, then repair the existing baseline so the new quality gates pass cleanly. Document the local commands alongside the existing pytest check. Constraint: CI currently installs the dev dependency group before running checks. Rejected: Add mypy with broad ignores | would create a weak gate that passes without checking the current source baseline. Rejected: Typecheck tests immediately | source-level checking gives a smaller first gate while tests remain covered by Ruff and pytest. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep CI lint/typecheck commands aligned with the README Development Checks section. Tested: uv run ruff check . Tested: uv run mypy Tested: uv run pytest Tested: git diff --check
hzhaoy
added a commit
that referenced
this pull request
Jul 7, 2026
Expand the Ruff gate to cover import ordering, bugbear, comprehensions, pyupgrade, and simplify rules while deferring line-length cleanup. Add Ruff format checking to CI and normalize the current tree so the new formatter gate starts green. Constraint: The repository already runs Ruff, mypy, and pytest in CI after PR #13. Rejected: Enable E501 immediately | the current tree has many long lines, and line-length cleanup would dominate this ruleset PR. Rejected: Add format check without formatting the tree | CI would fail immediately on existing files. Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep Ruff select/ignore and README check commands aligned with the PR workflow. Tested: uv run ruff format --check . Tested: uv run ruff check . Tested: uv run mypy Tested: uv run pytest Tested: git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv run ruff check .anduv run mypybefore pytest.check_untyped_defs.Validation
uv run ruff check .uv run mypyuv run pytestgit diff --checkuv lock --check