[codex] Keep TUI prompt flow recoverable#12
Merged
Conversation
Add in-memory prompt history for the TUI composer so arrow navigation recalls recent prompts without breaking slash-command completion. Guard transcript clearing while an inline approval card is still pending so the callback that resumes an interrupted stream remains reachable. Constraint: Inline HITL approvals are mounted inside the chat transcript. Rejected: Preserve only approval widgets during clear | leaves users with detached approval context after erasing the surrounding transcript. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Do not clear pending approval widgets without preserving a usable resume decision path. Tested: uv run pytest Tested: git diff --check
hzhaoy
marked this pull request as ready for review
July 6, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The input box already captured Up/Down for slash-command suggestions, which meant normal prompt history navigation could not work. Separately, inline approval requests now live inside the chat log, so clearing the transcript during an approval could remove the only widget holding the decision callback and leave the interrupted stream stuck.
Validation
uv run pytestgit diff --check