Move defaultEventNames into Schema

[grncdr]

This allows applications to extend the mapping with support for custom elements.

Closes #660

See also: this comment #661 (comment)

[lb-]

Just a few thoughts, I think this would be an awesome feature and helps for mixed adoption of Web Components.

[lb-]

Suggested change

	defaultEventNames: {
	defaultEventMappings: {

Since we use the term mappings already, might be nice to align with that naming?

[grncdr]

Obsoleted by 2ddac5f

[grncdr]

I ended up dropping 2ddac5f so this is relevant again. I'm open to renaming it.

[lb-]

This probably needs docs also

[grncdr]

This probably needs docs also

Definitely up for adding docs. Can I interpret your review as tacit support for this implementation vs. #661?

[lb-]

I'm not on the core team - but I love the idea of this feature so it gets my vote 👍

[marcoroth]

Thanks for proposing two solutions for issue #660, @grncdr!

In case we are going to combine this and #661 I left some small remarks in this pull request. Otherwise this looks good to me. Thanks for working on this.

[grncdr]

This now takes into account the feedback on #661 as well, setting on an Application#registerDefaultEventNames method.

I opted for the plural form of the name and passing an object because it felt nicer to write this:

app.registerDefaultEventNames({
  'sl-button': 'click',
  'sl-select': 'change',
  'sl-input': 'input',
  // etc.
})

vs this:

app.registerDefaultEventName('sl-button', 'click')
app.registerDefaultEventName('sl-select', 'change')
app.registerdDefaultEventName('sl-input', 'click')
// etc.

... but I'm open to changing it back to registerDefaultEventName.

---

Other concerns

There's a limitation (also covered in the docs) where this API won't work when calling Application.start() as a static method. You need to register default event names before the application starts or it won't properly bind listeners. If somebody really wants to use the static method, overriding the Schema passed to start is still possible:

Application.start(document.body, {
  ...defaultSchema,
  defaultEventNames: {
    ...defaultSchema.defaultEventNames,
    'sl-button': 'click',
    // etc.
  }
})