Skip to content

Add --search-domains flag to dns options command #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuaboniface wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add --search-domains flag to dns options command #655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7614e62
Add --search-domains flag to dns options command
joshuaboniface Feb 19, 2026
765abfe
Apply review suggestion for slog.Debug
joshuaboniface May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmd/dns_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ running Home Assistant DNS server.
`,
Example: `
ha dns options --servers dns://8.8.8.8 --servers dns://1.1.1.1
ha dns options --search-domains example.com --search-domains corp.example.com
`,
ValidArgsFunction: cobra.NoFileCompletions,
Args: cobra.NoArgs,
Expand All @@ -35,6 +36,13 @@ running Home Assistant DNS server.
options["servers"] = servers
}

searchDomains, err := cmd.Flags().GetStringArray("search-domains")
slog.Debug("search-domains", "search-domains", searchDomains)

if cmd.Flags().Changed("search-domains") && err == nil {
options["search_domains"] = searchDomains
}
Comment thread
joshuaboniface marked this conversation as resolved.

data, err := cmd.Flags().GetBool("fallback")
if err == nil && cmd.Flags().Changed("fallback") {
options["fallback"] = data
Expand All @@ -52,11 +60,13 @@ running Home Assistant DNS server.

func init() {
dnsOptionsCmd.Flags().StringArrayP("servers", "r", []string{}, "Upstream DNS servers to use. Use multiple times for multiple servers.")
dnsOptionsCmd.Flags().StringArray("search-domains", []string{}, "DNS search domains written to container resolv.conf. Use multiple times for multiple domains.")
dnsOptionsCmd.Flags().BoolP("fallback", "", true, "Enable/Disable fallback DNS (Cloudflare DoT)")

dnsOptionsCmd.Flags().Lookup("fallback").NoOptDefVal = "true"

dnsOptionsCmd.RegisterFlagCompletionFunc("servers", cobra.NoFileCompletions)
dnsOptionsCmd.RegisterFlagCompletionFunc("search-domains", cobra.NoFileCompletions)
dnsOptionsCmd.RegisterFlagCompletionFunc("fallback", boolCompletions)

dnsCmd.AddCommand(dnsOptionsCmd)
Expand Down