Color scheme#220
Open
xiangcy wants to merge 2 commits into
Open
Conversation
Member
I would add color scheme selection to the preferences module/view. Currently it only supports hotkeys, checkboxes, text-inputs, and number-inputs so you'll need to extend it to support a select field.
Don't. Take a look at how toggle the editor toolbar in .scheme-red .my-other-selector {
/* stuff */
}
Clean up the CSS (sorry)... Also, you don't need to change every CSS rule, just open up the element inspector and start adding new css rules until you get it to look how you want. Also, I would put each scheme in a separate file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very scratch version. Have three problems:
Steven, do you have any suggestions? Thank you!