Derive edge image registry from a single ecrRegistry value#435
Open
timmarkhuff wants to merge 3 commits into
Open
Derive edge image registry from a single ecrRegistry value#435timmarkhuff wants to merge 3 commits into
timmarkhuff wants to merge 3 commits into
Conversation
The edge-endpoint and inference-server image references hardcoded the GL_Public ECR host (767397850842.dkr.ecr.us-west-2.amazonaws.com) independently, alongside the existing ecrRegistry value already used for the registry-credentials pull secret. Collapse all three onto the single ecrRegistry value so the registry host has one source of truth. No behavior change: ecrRegistry still defaults to the GL_Public host, so the rendered image strings are byte-identical. This sets up a later switch to derive the registry per environment from upstreamEndpoint once the dedicated Axon edge ECR accounts exist. Co-authored-by: Cursor <cursoragent@cursor.com>
timmarkhuff
changed the title
Build the registry-switching seam now rather than deferring it. A chart-local ecrRegistryMap keys the ECR image base (registry host plus optional repo prefix) off upstreamEndpoint, the signal edge installs already provide, so no new install argument is introduced. Two helpers consume it: ecrRegistry (full image base, for the edge-endpoint and inference images) and ecrRegistryHost (host portion only, for the registry-credentials pull secret docker-server, which keys on the host). An explicit ecrRegistry value still overrides the map, and upstreams absent from the map fall back to the prod (api.groundlight.ai) entry, so self-hosted installs are unaffected. No behavior change: the only map entry points at the GL_Public host, so the default and fallback both render the byte-identical image strings as before. When the dedicated Axon edge ECR accounts exist (aws-global #371), adding their host plus the edge/ repo prefix (and jetson repo naming) to the map flips the switch as a data-only change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
edge-endpointand inference-server images each hardcoded the GL_Public ECR host (767397850842.dkr.ecr.us-west-2.amazonaws.com), separate from theecrRegistryvalue already used for theregistry-credentialspull secret. This routes all three through a chart-local resolver keyed offupstreamEndpoint(the signal edge installs already provide), so no new install argument is added.ecrRegistryMap(values.yaml) mapsupstreamEndpoint-> ECR image base (registry host + optional repo prefix)ecrRegistryhelper -> full image base, used by the edge-endpoint and inference imagesecrRegistryHosthelper -> host portion only, used by the pull-secret--docker-server(which keys on the host, not the prefix)ecrRegistryvalue still overrides the map; upstreams absent from the map fall back to the prod (api.groundlight.ai) entryNo behavior change
The only map entry points at the GL_Public host, so the default and the fallback both render byte-identical image strings. Verified the full chart renders cleanly and that the override and unmapped-upstream branches resolve as expected:
api.groundlight.ai)767397850842.dkr.ecr.us-west-2.amazonaws.com999.../edge999.../edge999...amazonaws.com(prefix stripped)767...Why
Establishes the registry-switching seam now so the move to the dedicated Axon edge ECR accounts (aws-global #371) is a data-only map edit: add the account host plus the
edge/repo prefix (and jetson repo naming).