Update powsybl-network-viewer to v3.6.0#4092
Conversation
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
📝 WalkthroughWalkthroughChangesNetwork Viewer Dependency Update
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
package.jsonOops! Something went wrong! :( ESLint: 9.39.4 A configuration object specifies rule "import-x/no-cycle", but could not find plugin "import-x". Common causes of this problem include:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
22-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCheck if the
newGSMapEquipmentForUpdatehack can now be removed.
src/components/network/gs-map-equipments.ts:118-125contains a duplicatednewGSMapEquipmentForUpdatemethod with a TODO noting it was needed becausenewMapEquipmentForUpdate's return type (typeof this) was removed from the exported.d.tssince powsybl-network-viewer PR#174. Now that the dependency is bumped to3.6.0, verify whether this issue has been resolved upstream. If so, the hack and duplicate method can be cleaned up in a follow-up.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 22, Verify whether `@powsybl/network-viewer` 3.6.0 restores the exported return type for newMapEquipmentForUpdate; if resolved, remove the duplicated newGSMapEquipmentForUpdate method and its TODO workaround from the GS map equipment implementation, then update callers as needed to use newMapEquipmentForUpdate directly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Line 22: Verify whether `@powsybl/network-viewer` 3.6.0 restores the exported
return type for newMapEquipmentForUpdate; if resolved, remove the duplicated
newGSMapEquipmentForUpdate method and its TODO workaround from the GS map
equipment implementation, then update callers as needed to use
newMapEquipmentForUpdate directly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 17f40aa7-5b9d-4bda-a717-c158431268f0
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
|



PR Summary
update the dependency to v3.6.0