Skip to content

Update powsybl-network-viewer to v3.6.0#4092

Open
sBouzols wants to merge 2 commits into
mainfrom
update-powsybl-networ-viewer-3.6.0
Open

Update powsybl-network-viewer to v3.6.0#4092
sBouzols wants to merge 2 commits into
mainfrom
update-powsybl-networ-viewer-3.6.0

Conversation

@sBouzols

Copy link
Copy Markdown
Contributor

PR Summary

update the dependency to v3.6.0

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Network Viewer Dependency Update

Layer / File(s) Summary
Update network viewer dependency
package.json
Updates @powsybl/network-viewer from version 3.5.1 to 3.6.0.

Suggested reviewers: souissimai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the dependency version update in this pull request.
Description check ✅ Passed The description directly matches the dependency upgrade shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Oops! Something went wrong! :(

ESLint: 9.39.4

A configuration object specifies rule "import-x/no-cycle", but could not find plugin "import-x".

Common causes of this problem include:

  1. The "import-x" plugin is not defined in your configuration file.
  2. The "import-x" plugin is not defined within the same configuration object in which the "import-x/no-cycle" rule is applied.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

22-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Check if the newGSMapEquipmentForUpdate hack can now be removed.

src/components/network/gs-map-equipments.ts:118-125 contains a duplicated newGSMapEquipmentForUpdate method with a TODO noting it was needed because newMapEquipmentForUpdate's return type (typeof this) was removed from the exported .d.ts since powsybl-network-viewer PR #174. Now that the dependency is bumped to 3.6.0, verify whether this issue has been resolved upstream. If so, the hack and duplicate method can be cleaned up in a follow-up.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 22, Verify whether `@powsybl/network-viewer` 3.6.0
restores the exported return type for newMapEquipmentForUpdate; if resolved,
remove the duplicated newGSMapEquipmentForUpdate method and its TODO workaround
from the GS map equipment implementation, then update callers as needed to use
newMapEquipmentForUpdate directly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@package.json`:
- Line 22: Verify whether `@powsybl/network-viewer` 3.6.0 restores the exported
return type for newMapEquipmentForUpdate; if resolved, remove the duplicated
newGSMapEquipmentForUpdate method and its TODO workaround from the GS map
equipment implementation, then update callers as needed to use
newMapEquipmentForUpdate directly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 17f40aa7-5b9d-4bda-a717-c158431268f0

📥 Commits

Reviewing files that changed from the base of the PR and between 05bc594 and 5d363fa.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants