Skip to content

Use the new Managed Export CSV Button#4075

Open
khouadrired wants to merge 9 commits into
mainfrom
refactor-exportcsv-button
Open

Use the new Managed Export CSV Button#4075
khouadrired wants to merge 9 commits into
mainfrom
refactor-exportcsv-button

Conversation

@khouadrired

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

This comment was marked as outdated.

@khouadrired khouadrired force-pushed the refactor-exportcsv-button branch from ca75d9b to 763051a Compare July 2, 2026 15:57
coderabbitai[bot]

This comment was marked as outdated.

columns={columns}
tableName={tableName}
disabled={isRowsEmpty}
disabled={!isRowsEmpty}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change ?
Export button is now disabled if there are results available in loadflow, voltage init and state estimation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

const fileBlob = await downloadZipResult(
studyUuid as UUID,
nodeUuid as UUID,
currentRootNetworkUuid as UUID,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These casts are useless ...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casts removed

csvHeaders={csvHeaders}
nOrNkIndex={nOrNkIndex}
sensiKind={sensiTab}
<ManagedExportCsvButton

@FranckLecuyer FranckLecuyer Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csv headers are not properly translated anymore (sometimes in english when it should be french, and sometimes in french when it should be in english) :

But this error is already present (not introduced by this PR), and fields separators are ok in the exported csv

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the last commit : 030ccd5

nodeUuid={nodeUuid}
currentRootNetworkUuid={currentRootNetworkUuid}
csvHeaders={csvHeaders}
<ManagedExportCsvButton

@FranckLecuyer FranckLecuyer Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csv headers are not properly translated anymore (sometimes in english when it should be french, and sometimes in french when it should be in english) :

But this error is already present (not introduced in this PR), and fields separators are ok in the exported csv

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the last commit : 030ccd5

FranckLecuyer and others added 4 commits July 8, 2026 15:26
@FranckLecuyer FranckLecuyer self-requested a review July 9, 2026 11:36

@FranckLecuyer FranckLecuyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests: some fixes added (see 2 last commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants