Clear file state on equipment type change in tabular forms#4070
Open
flomillot wants to merge 6 commits into
Open
Clear file state on equipment type change in tabular forms#4070flomillot wants to merge 6 commits into
flomillot wants to merge 6 commits into
Conversation
In the tabular and limit-sets modification forms, the file/import state (selected file, file error/warning, CSV filename) was only reset through resetOnConfirmation, which runs only when the confirmation popup opens (i.e. when the table is non-empty). Changing the type on an empty table skipped the popup and left a stale selected file or file message from the previous type. Split the reset: the destructive table/properties reset stays behind confirmation (resetOnConfirmation), while the file state is now cleared on every type change through the new resetOnChange prop of InputWithPopupConfirmation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughBoth tabular form components split a combined type-change reset into separate file-state and form/table-state callbacks, then wire them to ChangesSplit type-change reset callbacks
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This tolerance is handled in a dedicated change; drop it here to avoid duplicating it across pull requests. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
basseche
approved these changes
Jul 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the tabular and limit-sets modification forms, the file/import state (selected file, file error/warning, CSV filename) was reset only through
resetOnConfirmation, which runs only when the confirmation popup opens — i.e. when the table is non-empty. Changing the equipment type on an empty table skipped the popup, leaving a stale selected file or file message from the previous type.The reset is now split:
resetOnConfirmation— the destructive table/properties reset stays gated behind confirmation.resetOnChange— the file state is cleared on every type change.Dependency
Relies on the new
resetOnChangeprop ofInputWithPopupConfirmation: gridsuite/commons-ui#1216. Requires that change to be released before this one is functional.