-
Notifications
You must be signed in to change notification settings - Fork 231
Add Kusto DB and kql support #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e1fe58a
Add Kusto DB and kql support
tanmoyio 66363dc
tenant id
tanmoyio a970ab6
tagging numpy temp
tanmoyio 49ae11c
Plugins: Give more flexibility to the user how to init client
exrhizo a201d1a
fix: errors in kustograph
exrhizo 68c5811
Plugin runtime fixes and respond to comments
exrhizo a6120fb
Plugins, open close session, kusto unwrap heuristic,
exrhizo a1f47f1
fix column types
exrhizo 56a0f9d
Kusto query and query_graph doc strings
exrhizo f9e7a71
dynamic type handle
tanmoyio 335f88d
more dynamic type handling
tanmoyio b4ca09f
remove pinned numpy
tanmoyio ee76ee0
lint
tanmoyio 9e0dee5
mypy fixes
tanmoyio 15e2403
mypy fix
tanmoyio 2ad2ec4
more mypy fixes
tanmoyio 42a02e0
mypy fixes
tanmoyio 806ff25
Merge branch 'master' into feat/kusto
tanmoyio 9d12734
mypy fix
tanmoyio 23499ab
update readme
tanmoyio 5bb5389
Version and date to be added later
tanmoyio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from an ergonomics, esp forward looking, would it be cleaner to be like
so:
kql()- main call: short method namekql(str) -> df | list[df] | plottablekql<T>(str) -> T?kql_{df,dfs,g}(str) -> T- main call, typed variants: when return type is knownkusto_config()- initial call: separate out askusto_config()There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately, touching on the whole connection lifecycle question, I'm wondering about connection lifecycles here:
some variants:
kusto_config()sets a config but doesn't connect, so if a bad cfg, we don't know, and connections managed laterkusto_config()creates a connected client (and downstream use maintains?), and so it needs to be closed tookusto_config()creates a connected client, but if it disconnects, on the user to reconnect somehow?