feat(storage): expose object_metadata on AsyncMultiRangeDownloader#17411
Open
yuxin00j wants to merge 3 commits into
Open
feat(storage): expose object_metadata on AsyncMultiRangeDownloader#17411yuxin00j wants to merge 3 commits into
yuxin00j wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds tracking for object metadata in the AsyncMultiRangeDownloader class by initializing and copying object_metadata from the underlying stream. The reviewer suggests refactoring this attribute into a read-only property that dynamically delegates to the stream, which simplifies the code by removing the need for manual assignments in multiple places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
object_metadataattribute on theAsyncMultiRangeDownloaderclass.Context
In PR #17261,
object_metadatawas successfully exposed on theAsyncReadObjectStream. However, it was not surfaced on theAsyncMultiRangeDownloader(MRD), meaning high-level libraries relying on MRD (likefsspec/gcsfs) cannot access the underlying gRPC metadata.By inheriting and surfacing
self.object_metadata = self.read_obj_str.object_metadata, this allows downstream users to completely bypass redundantRESTinfo()API calls and extract fields likecrc32c,size, andgenerationdirectly from the MRD instance.cc @chandra-siri