host: vulkan: check YCbCr format features before creating samplers#164
Merged
Conversation
During YcbcrSamplerPool initialization, getOrCreateSamplerInfo called vkCreateSamplerYcbcrConversion and vkCreateSampler without checking if the host Vulkan driver supported YCbCr sampler conversion features for the given format. On host GPU drivers lacking YCbCr sampler support for prepopulated formats (e.g. Intel Gen12 Mesa driver), this triggered a null pointer dereference inside driver vkCreateSampler. Check VK_FORMAT_FEATURE_MIDPOINT_CHROMA_SAMPLES_BIT, VK_FORMAT_FEATURE_COSITED_CHROMA_SAMPLES_BIT, and VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER_BIT in getOrCreateSamplerInfo before sampler creation, and log a verbose message instead of failing pool init when prepopulation is skipped. TEST: run crosvm on redrix with gfxstream vulkan
jmacnak
approved these changes
Jul 21, 2026
jmacnak
enabled auto-merge
July 21, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During YcbcrSamplerPool initialization, getOrCreateSamplerInfo called vkCreateSamplerYcbcrConversion and vkCreateSampler without checking if the host Vulkan driver supported YCbCr sampler conversion features for the given format. On host GPU drivers lacking YCbCr sampler support for prepopulated formats (e.g. Intel Gen12 Mesa driver), this triggered a null pointer dereference inside driver vkCreateSampler.
Check VK_FORMAT_FEATURE_MIDPOINT_CHROMA_SAMPLES_BIT, VK_FORMAT_FEATURE_COSITED_CHROMA_SAMPLES_BIT, and
VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER_BIT in getOrCreateSamplerInfo before sampler creation, and log a verbose message instead of failing pool init when prepopulation is skipped.
TEST: run crosvm on redrix with gfxstream vulkan