vulkan: Treat zero-size buffer transfers as no-ops#163
Open
utzcoz wants to merge 1 commit into
Open
Conversation
A guest-controlled transfer with an in-range offset and size 0 passed the bounds check and recorded a VkBufferCopy with size 0, which the Vulkan spec forbids (VUID-VkBufferCopy-size-01988). Return success without touching the device instead, in both readBufferToBytes and updateBufferFromBytes. Zero-size transfers with an out-of-range offset are still rejected. Test: bazel test //host/vulkan:vk_common_operations_tests Change-Id: I641878b897b41c7476d14e66380bf86d6908e9f4
Contributor
Author
|
Hi @jmacnak , PTAL. Thanks. |
Contributor
Author
|
|
Contributor
Author
|
Hi @jmacnak , could you help to review this PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A guest-controlled transfer with an in-range offset and size 0 passed the bounds check and recorded a VkBufferCopy with size 0, which the Vulkan spec forbids (VUID-VkBufferCopy-size-01988). Return success without touching the device instead, in both readBufferToBytes and updateBufferFromBytes. Zero-size transfers with an out-of-range offset are still rejected.
Test: bazel test //host/vulkan:vk_common_operations_tests
Change-Id: I641878b897b41c7476d14e66380bf86d6908e9f4