Add tests for web dependency pages and restore COVER_MIN to 75#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
internal/http/web/deps_pages_test.gocovering/dependencies,/dependencies/blame,/dependencies/stats, and/dependencies/{purl}. The fixture seeds a two-commit repo with ago.mod, reindexes through apkgs.Storeinjected viaWithPkgsStore, and asserts status, content type, and body content. Also covers the indexing banner andpurlPackageName.Overall
./internal/...coverage 73.8% → 77.5%, soCOVER_MINgoes back to 75.The tests surfaced a bug in
purlPackageName: it cut at the first@, so npm scoped packages likepkg:npm/%40babel/core@7.24.0returned an empty name. Replaced the hand-rolled parser withpurl.Parse(s).FullName()fromgit-pkgs/purl, which also gives the right separator per ecosystem (e.g.org.junit:junitfor maven).indexByteFromis removed.