Implemented uniformal xml insertion when creating an adapter or configuration file#550
Conversation
…ing to improve path normalization and response types
stijnpotters1
force-pushed
the
fix/default-xml-insertion
branch
from
3cc6324 to
2c2ffdf
Compare
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
2 things
I see that creating a new adapter now also returns the xmlcontent to the frontend, why is this done like this instead of returning a http 204 and loading the content once the file is opened?
You now look through the adapters inside the xml to open the file in the studio but isnt there existing functionality for this? Or maybe creating a new file doenst immedately have to open it in the studio but instead open the studio file browser on the right folder so the user can choose
I see a lot of replace('\\', '/'), maybe we should always do this to paths coming from the filesystem so we dont have to do this everywhere all the time in both back and frontend
…dapter location response
Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
…ramework/flow into fix/default-xml-insertion
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
I still see a few strange places in the frontend where normalizePath() is used, are you sure the paths can't be normalized before getting to those points?
Other than that a couple of small things but looks good so far!
|
3 participants
first merge #549