test: verify against shared cross-SDK signature vectors#36
Merged
Conversation
add tests/signature-vectors.json (generated from pkg/signature) and a jest harness asserting each vector: valid signatures verify, invalid, forged, expired and malformed ones throw. matches the canonical set used by the other convoy SDKs.
|
Current version of PR was reviewed by /review-bugbot with additional instructions on Jul 13, 12:39 GMT+1. It flagged 0 findings. Bugbot on commit |
motunrayokoyejo
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/signature-vectors.json) +tests/shared-vectors.test.ts.Test plan
jest