Skip to content

Fix tab navigation active state persistence#141

Merged
roncodes merged 2 commits into
mainfrom
dev-v0.3.40
Jul 2, 2026
Merged

Fix tab navigation active state persistence#141
roncodes merged 2 commits into
mainfrom
dev-v0.3.40

Conversation

@roncodes

@roncodes roncodes commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Preserve uncontrolled TabNavigation active state when refreshed tab arrays contain the current id
  • Fall back to the first tab only when the active id is removed
  • Add regression tests for refreshed tabs and removed active tabs

Validation

  • npx eslint addon/components/tab-navigation.js tests/integration/components/tab-navigation-test.js
  • npx ember test --filter 'Integration | Component | tab-navigation' builds, then local Testem fails before browser execution because testem requires ESM-only execa@9.6.1

@roncodes roncodes changed the title [codex] Fix tab navigation active state persistence Fix tab navigation active state persistence Jul 2, 2026
@roncodes roncodes marked this pull request as ready for review July 2, 2026 04:18
@roncodes roncodes merged commit f2e0c47 into main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant