Fix typo in language-list (phpunit test) [no important files changed]#972
Conversation
[no important files changed]
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
left a comment
mk-mxp
left a comment
There was a problem hiding this comment.
Thanks for pointing this out!
| * @task_id 4 | ||
| */ | ||
| #[TestDox('when pushing, original is unchanged')] | ||
| #[TestDox('when removing, original is unchanged')] |
There was a problem hiding this comment.
It's better to use the actual function verb 'prune' here, as the list is emptied out completely and not only some things are removed:
| #[TestDox('when removing, original is unchanged')] | |
| #[TestDox('when pruning, original is unchanged')] |
There was a problem hiding this comment.
I have hesitated ... (I am not English native).
Thanks for pointing this.
There was a problem hiding this comment.
No worries, I'm not a native English speaker, too.
mk-mxp
added
x:action/fix
2 participants
This pull request fix a typo in LanguageListTest.php
[no important files changed]