Add type as part of target location

[aosen-xiong]

Merge with eisop/jdk#134.

[aosen-xiong]

Hi @wmdietl, do you know how to update the elementcache in

checker-framework/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java

Line 529 in c29e50b

private final Map<Element, AnnotatedTypeMirror> elementCache;

.

It is later retrieved at here.

checker-framework/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java

Line 1663 in c29e50b

return elementCache.get(elt).deepCopy();

The expected error did not come up because in the elementCache it does not contain annotation added from DefaultQualifier.

[aosen-xiong]

The root cause should be here as the method getTypeDeclarationBounds

checker-framework/framework/src/main/java/org/checkerframework/common/basetype/BaseTypeValidator.java

Line 318 in 93f44a2

atypeFactory.getTypeDeclarationBounds(type.getUnderlyingType());

which does not consider bound in Defaultqualifier annotation like @DefaultQualifier( value = A.class, locations = {TypeUseLocation.TYPE})

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for applying @DefaultQualifier at a new TypeUseLocation.TYPE to default top-level class/interface/enum/record types, along with a regression test.

Changes:

• Introduce TypeUseLocation.TYPE enum constant and documentation.
• Apply defaults for TYPE in QualifierDefaults using the element cache to detect/avoid conflicting annotations.
• Add a viewpoint test that exercises invalid annotation interactions with the new TYPE location.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
framework/tests/viewpointtest/DefaultQualifierTest.java	Adds a regression test for defaulting behavior at TypeUseLocation.TYPE.
framework/src/main/java/org/checkerframework/framework/util/defaults/QualifierDefaults.java	Implements default application logic for the new TYPE location.
framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java	Exposes the element cache for use in defaulting logic.
checker-qual/src/main/java/org/checkerframework/framework/qual/TypeUseLocation.java	Adds TYPE as a new location and documents its semantics.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.