Skip to content

Convert objects to arrays#10

Open
ffes wants to merge 3 commits into
editorconfig:masterfrom
ffes:objects-to-arrays
Open

Convert objects to arrays#10
ffes wants to merge 3 commits into
editorconfig:masterfrom
ffes:objects-to-arrays

Conversation

@ffes

@ffes ffes commented Dec 15, 2017

Copy link
Copy Markdown
Member

Closes #2, closes #3, closes #4

This PR works towards the initial release of the editorconfig-defaults.json file.

matches and flavors are now arrays instead of objects. This makes the schema a lot less complicated and easier to validate.

@florianb and/or @deinok could you please review this PR?

@ffes ffes added the schema label Dec 15, 2017
@deinok

deinok commented Dec 15, 2017

Copy link
Copy Markdown

Hi @ffes
Could you please order the JSON attributes of the two files or atleast in the editorconfig-defaults.schema.json and commit again?
You can use this -> http://novicelab.org/jsonabc/
It will be easier to review ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema: should "<<matchers>>" be specified in the schema? Schema: validator says "indent_style = 1" is valid Schema: "editorconfig" not complete

2 participants