Connections#25336
Conversation
Introduce a new Enterprise > Security section for Docker OIDC, positioned between Enforce sign-in and Roles and permissions. Adds overview, connection management, and rulesets/subject claims pages, including GitHub Actions workflow setup and Admin Console management guidance. Also adds a Docker OIDC card to the Security landing page and registers the feature in summary.yaml for summary-bar metadata.
Correct links and wording, align login-action with repo convention, and update the Security grid icon.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
New Docker OIDC documentation is well-structured and technically clear. One high-severity inconsistency between the prose and the rendered summary-bar subscription badge needs resolution before merge, plus several medium style issues.
|
|
||
| Each ruleset contains the following fields: | ||
|
|
||
| - **Label**: A name for the ruleset. |
There was a problem hiding this comment.
[MEDIUM] Bold used for conceptual list labels — may not qualify as UI elements
STYLE.md reserves bold exclusively for UI elements (buttons, menus, field labels). **Label**, **Rules**, **Resources**, and **Scopes** appear in a conceptual definition list. If these are the exact names of labeled fields in the Admin Console form UI, bold is correct. If they're conceptual terms describing what a ruleset contains, bold should be removed and the list rewritten as plain prose bullets.
There was a problem hiding this comment.
These are the exact names of the UI elements
There was a problem hiding this comment.
Thank you for confirming! In that case, the bold formatting is correct per STYLE.md. Resolved.
| - While a connection is deactivated: | ||
| - It cannot issue Docker access tokens. | ||
| - Without Docker access tokens, the `docker/oidc-action` step references will fail at the token-exchange step until you activate the connection. | ||
| - Deactivation is useful when rotating credentials: pause the existing connection while you configure its replacement. |
There was a problem hiding this comment.
this is inaccurate and updated locally; hold over from the november draft
2 participants
Draft PR