guides: refresh nodejs#25319
Conversation
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
This PR is a substantial improvement — it replaces a bloated, marketing-heavy full-stack Node.js guide with a clean, focused Express API tutorial using Docker Hardened Images, Compose secrets, Vitest, and supply chain attestations. Writing quality is strong: hedge words, marketing language, and the 'we' perspective are largely absent. Two medium-severity issues need attention before merge.
craig-osterhout
force-pushed
the
node-refresh-dhierize
branch
from
e46bd4b to
000c28d
Compare
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
craig-osterhout
force-pushed
the
node-refresh-dhierize
branch
3 times, most recently
from
a87c54f to
fdc28f7
Compare
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
craig-osterhout
force-pushed
the
node-refresh-dhierize
branch
from
65d4298 to
36b9f5b
Compare
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
LGTM. Just a general thought though. Some of the chapters in these guides are not centered around node.js development; GHA, deploy, supply chain security. And we have other guides explaining those concepts specifically.
We might want to put these on a diet at some point, and make them focused on one idea rather than try to cover SDLC end-to-end when the steps we describe are really lang/framework agnostic. Shorter is better, and easier to read in one sitting (and also easier to maintain and review).
- Convert every directory-based guide from a branch bundle (_index.md = section) to a leaf bundle (index.md = single page). URLs and any co-located images are preserved; the guides are now kind=page, not sections. - Re-collapse the Node.js guide on top of main's refresh (docker#25319): merge the refreshed containerize/develop/run-tests/configure-github-actions/ secure-supply-chain/deploy topics into one page, drop the languages field, move tags under params ([languages]), and add aliases for the old /guides/nodejs/<topic>/ URLs. - Landing: enumerate guides with RegularPagesRecursive instead of .Pages so every guide is listed (now that they're regular pages), including the nested frameworks/laravel guide that the non-recursive .Pages missed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 participants
Description
Refreshed Node.js guide
https://deploy-preview-25319--docsdocker.netlify.app/guides/nodejs/
Related issues or tickets
ENGDOCS-3319
Closes #25280
Reviews