docs: update Go SDK guide for explicit toolset registry and MCP OAuth token persistence#3193
Open
aheritier wants to merge 2 commits into
Open
docs: update Go SDK guide for explicit toolset registry and MCP OAuth token persistence#3193aheritier wants to merge 2 commits into
aheritier wants to merge 2 commits into
Conversation
PR #3184 replaced the blank-import opt-in pattern with an explicit toolset registry (pkg/teamloader/toolsets). The RAG toolset is now included in NewDefaultToolsetRegistry() by default. Document the opt-out pattern (delete creators["rag"] from the registry) for binaries that want a load-time warning rather than a deferred runtime error. Note that teamloader.Load() does not return an error for unknown toolset types — failures become load-time warnings attached to the agent. Clarify that pkg/rag/treesitter build-tag guards handle the cgo boundary automatically regardless of CGO_ENABLED.
PR #3189 decoupled the OS keyring token store from the embedder packages. The CLI calls keyringstore.Register() at startup; embedders that want persistent MCP OAuth tokens across restarts must call it before teamloader.Load() on configs with remote MCP toolsets. Document the Register() call, the panic trigger (MCP toolset construction, not OAuth lookup), and when to omit it.
aheritier
added
area/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to
docs/guides/go-sdk/index.mdfor two merged PRs.PR #3184 (refactor: make toolsets and providers explicit): The RAG toolset is now included in
NewDefaultToolsetRegistry()by default viapkg/teamloader/toolsets— no blank import needed. Updated the Go SDK guide to replace the opt-in blank-import pattern with the new opt-out registry pattern for binaries that want a load-time warning rather than a deferred runtime error from the!cgostub.PR #3189 (refactor: decouple embedder deps): The OS keyring token store for MCP OAuth is now opt-in for library embedders. The CLI calls
keyringstore.Register()at startup; embedders must call it themselves beforeteamloader.Load()on configs with remote MCP toolsets, or tokens are in-memory only. Added a new section documenting this, including the panic on late registration.PRs reviewed and found no docs impact: #3190 (CHANGELOG), #3187 (remove unused wasm agent), #3183 (prior docs update), #3181 (lean TUI — docs included in PR itself), #3179 (CHANGELOG), #3178 (thinking cycle — covered by #3183).