Conversation
fix(deps): upgrade yaml.v2 to v3 and golang.org/x/net
- Add SetNotFoundHandle method to Group interface - Add notFoundHandler field to xGroup struct - Group-level NotFoundHandler takes priority over app-level - Update server.groups type from []Group to []*xGroup Resolves: #229
feat(group): add SetNotFoundHandle support for router groups
# Conflicts: # .github/workflows/go.yml
- Add SetNotFoundHandle method to Group interface - Add notFoundHandler field to xGroup struct - Group-level NotFoundHandler takes priority over app-level handler - Fix prefix matching to avoid false positives (e.g., /api_v2 matching /api) - Add unit tests for SetNotFoundHandle functionality - Add example code in example/group/ Resolves: #229
feat(group): add SetNotFoundHandle support for router groups
feat(group): add SetNotFoundHandle support for router groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage Example
Behavior
/api/users→ Returns "Users list"/api/unknown→ Returns JSON 404 response (group handler)/api_v2/test→ Returns global 404 (not matched by /api group)/unknown→ Returns global 404 (app handler)Test Plan
Resolves: #229