Bind execution requests to the registered venue type#23
Merged
Conversation
0xMuang
added a commit
that referenced
this pull request
Jul 14, 2026
Resolve the stacked PR branch after main advanced with the router venue binding fix, Phase 1 architecture baseline, and RFQ backend SDK documentation/code. Constraint: PR #24 must merge after #23 and before the higher stacked PRs. Rejected: Dropping either RFQ-002 or RFQ-SDK documentation state | both are accepted completed work on main/stack. Confidence: high Scope-risk: moderate Directive: Continue stacked PR merges in order after #24 lands: #25, #26, #27, #28, #29, #30. Tested: git diff --cached --check; scripts/check.sh Not-tested: GitHub CI after push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExecutionRouter validated the caller-supplied
context.venueTypeagainst the decision's type mask but never against the venue's registeredVenueConfig.venueType, so a caller could misreport the type and route through a disallowed-type venue. Adds a step-7a binding check (Errors.VenueTypeMismatch) after adapter resolution.Closes the remaining medium finding from the PR #12 review.
test_execute_revertsWhenVenueTypeMismatchesRegistry(mask set so only the new check can reject)forge test --offline: 124 passed