Refactor/perf batch 3#662
Merged
Merged
Conversation
…f permitted classes are not only numeric and int
…ferent element names
StuartWheater
requested changes
Jul 16, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
If the name of tar is to change name (added ".9000") the file "armadillo_azure-pipelines.yml" will need also changed. [Approx line 239]
Contributor
Author
Agh that wasn't intentional - will revert! |
1 similar comment
Contributor
Author
Agh that wasn't intentional - will revert! |
StuartWheater
approved these changes
Jul 16, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Replacement 'dsBase-v7.0.tar', and associated 'dsBase-v7.0-permissive.tar' fixes issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
isDefined()andcheckClass()and replace with serverside checks.checkClassConsistency()run on theclassfield already embedded in the function's normal result — no extra round-tripValidityMessagehandling removeddimDS/lengthDS/numNaDS)utils.R:.checkClassConsistency()generalised withfield+object_nameargs (handles classes returned under different element names, e.g.class.x,class.index)Tests
test-perf-for cor, corTest, cov, kurtosis, meanSdGp, quantileMean, skewness, summary, vartests/testthat/smk_expt-results/regenerated becauseds.meanno longer returns validity messagetest-arg-checks (moved to smoke); regeneratedds.meanfixturesOther
dsBase_7.0.0-permissive.tar.gzfor CI