Chore/frontend quality gates#2215
Merged
Merged
Conversation
added 3 commits
July 22, 2026 21:04
…y violations Dify-style "freeze legacy, block new" quality gates for both frontend apps: - ESLint 9 flat configs for platform, client and @bisheng/ui (shared toolchain installed at workspace root). House rules: no-explicit-any, no raw axios imports (C7), no-console (warn/error allowed), react-hooks rules as errors, ts-expect-error with description only. - Legacy violations frozen per app in eslint-suppressions.json (may only shrink; run lint:prune after cleaning a file). - TS strict via typescript-strict-plugin: legacy failing files annotated with @ts-strict-ignore (platform 388, client 163); all other and all new files fully strict-checked; tsc-strict wired as typecheck script. - platform tsconfig target es5 -> ES2020. - New CI workflow frontend-quality.yml: PR-triggered, path-filtered, lint + typecheck for both apps. - Gate policy documented in root AGENTS.md; @bisheng/ui starts at zero suppressions (fixed 1 dead var, removed 6 stale disable directives).
- add unist-util-visit as an explicit dependency (imported by MessageMarkDown.tsx but only resolvable via legacy hoisting; broke tsc-strict in CI's frozen-lockfile install) - FilterByUser.tsx: import debounce from lodash-es (declared) instead of lodash (undeclared, unresolvable in a clean install — would break vite build)
Same class of issue as the platform fix: modules imported directly but never declared, resolvable locally only via legacy node_modules leftovers, broken under CI's frozen-lockfile install. - add explicit deps: unist-util-visit, unified, dedent, @tanstack/react-virtual, @rc-component/mini-decimal, @radix-ui/react-slot (via workspace catalog) - useMessages.ts: import useParams from react-router-dom (declared) instead of react-router (undeclared transitive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
简要描述做了什么改动。
Why
为什么需要这个改动？
How
实现方式、设计决策（如有）。
Test
Related