fix: windows pipe - construct SDDL with user ID#157
Merged
Conversation
Signed-off-by: Mike Nguyen <hey@mike.ee>
JoshVanL
previously approved these changes
May 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Windows named-pipe security for the reload/hotreload mechanism by constructing the pipe SDDL using the current user’s identity (instead of the Creator Owner alias) to avoid downstream “access denied” issues when hotreloading is enabled.
Changes:
- Build the pipe
SecurityDescriptordynamically from the current user’s SID plusBA(Administrators) andSY(Local System). - Add a unit test to assert the generated SDDL contains the expected ACEs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
signals/pipe_windows.go |
Generates an SDDL string using the current user and applies it to winio.ListenPipe. |
signals/pipe_windows_test.go |
Adds a test validating the constructed SDDL format and principals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@mikeee these comments seem reasonable to add |
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Mike Nguyen <hey@mike.ee>
JoshVanL
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves access denied pipe issues downstream with hotreloading now enabled.
Tested working with the runtime in standalone mode
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: