Skip to content

Disable automated-trades dispatch on deploy#4636

Merged
AryanGodara merged 1 commit into
mainfrom
aryan/disable-automated-trades-dispatch
Jul 17, 2026
Merged

Disable automated-trades dispatch on deploy#4636
AryanGodara merged 1 commit into
mainfrom
aryan/disable-automated-trades-dispatch

Conversation

@AryanGodara

Copy link
Copy Markdown
Member

Description

Comment out the run-automated-trades repository-dispatch step in the deploy workflow, which fires on every push to main and asks infra repo to run automated test trades on all chains.

Unblocks merging cowprotocol/automated-trade#36

Changes

  • Comment out the "Dispatch automated trades to infrastructure repo" step in .github/workflows/deploy.yaml

@AryanGodara AryanGodara self-assigned this Jul 17, 2026
@AryanGodara
AryanGodara requested review from a team as code owners July 17, 2026 12:12
@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Claude finished @AryanGodara's task in 32s —— View job


PR Review: Disable automated-trades repo dispatch on deploy

  • Read the diff and surrounding workflow context
  • Assess correctness and impact

Summary

The change cleanly comments out the "Dispatch automated trades to infrastructure repo" step in .github/workflows/deploy.yaml. It's the last step in the deploy job, so nothing downstream depends on it — commenting it out won't break the rest of the workflow. The added comment (lines 154-155) clearly explains why it's disabled and links the tracking issue cowprotocol/automated-trade#36, which is exactly the right call for a temporary disable.

LGTM ✅ — no blocking issues.

A couple of optional thoughts (non-blocking, no change needed):

  • Commenting out vs. gating with if: is a reasonable choice here since the plan is to rework the step entirely rather than toggle it. Keeping the block (rather than deleting it) preserves the pinned action SHA and payload for easy re-enablement — good.
  • Consider whether a follow-up issue in this repo would help track the re-enablement, since automated-trade#36 lives in another repo and may be closed independently of this cleanup. Minor.
    aryan/disable-automated-trades-dispatch

@AryanGodara AryanGodara changed the title Disable automated-trades repo dispatch on deploy Disable automated-trades dispatch on deploy Jul 17, 2026
@AryanGodara
AryanGodara added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 195413e Jul 17, 2026
24 checks passed
@AryanGodara
AryanGodara deleted the aryan/disable-automated-trades-dispatch branch July 17, 2026 12:47
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants