Drop surplus_capturing_jit_order_owners table

[MartinquaXD]

Description

Follow up to #4613.
We had to drop the table 1 release after we stop using the table to not cause any issues during the rolling release when 2 autopilots are running.

Changes

drop surplus_capturing_jit_order_owners table and its documentation

[github-actions]

Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).

• If creating new tables, update the tables list.
• When adding a new index, consider using CREATE INDEX CONCURRENTLY for tables involved in the critical execution path.
• For breaking changes, remember that during rollout k8s starts the new autopilot, runs the Flyway migration, and only then shuts down the old pod. That overlap means the previous version can still be processing requests on the migrated schema, so make it compatible first and ship the breaking DB change in the following release.

---

Caused by:

• database/sql/V114__drop_surplus_capturing_jit_order_owners.sql

[claude]

Claude finished @MartinquaXD's task in 1m 19s —— View job

---

Review: Drop surplus_capturing_jit_order_owners table

• Read PR changes
• Verify no remaining code references to the table
• Verify migration numbering & conventions
• Post review

I posted 1 inline finding.

Summary: The intent is fine — the table's data was moved to competition_auctions, and the remaining surplus_capturing_jit_order_owners references in crates/database all point at the surviving competition_auctions column, not the dropped table. The version number 114 correctly follows V113.

The one blocking issue is that the migration file is missing the V prefix (114__… instead of V114__…), so Flyway would silently skip it and the table would never be dropped. Details in the inline comment.

[jmg-duarte]

🧹