updating problem definition for combinatorial auctions#507
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe documentation for the Cow Protocol auction mechanism was updated to clarify the uniform pricing constraint, correct the buy order scoring formula, simplify the fee explanation, and update the description of solver competition. No changes were made to code or exported/public entities. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/cow-protocol/reference/core/auctions/the_problem.md (1)
84-84: Refine phrasing for correctness and clarity.
Consider revising “From the protocol viewpoint” to “From the protocol’s viewpoint” and adding a comma before “and the fees paid to the protocol” to improve the sentence flow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cow-protocol/reference/core/auctions/the_problem.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/cow-protocol/reference/core/auctions/the_problem.md
[grammar] ~84-~84: It looks like you are using the wrong form of the noun or the verb. Did you mean “constraint has” or “constraints have”?
Context: ... each solution that satisfies the above constraints has a score that is given by the total su...
(NOUN_PLURAL_HAS)
[uncategorized] ~84-~84: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ... is given by the total surplus generated and the fees paid to the protocol, all aggr...
(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~84-~84: You might be missing the article “the” here.
Context: ...re of a solution is equal to the sum of scores of the orders the solution proposes to ...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[misspelling] ~89-~89: Did you mean “for sale”?
Context: ...en of the order (i.e., in the buy token for sell orders and in the sell token for buy or...
(FOR_SELL)
🔇 Additional comments (3)
docs/cow-protocol/reference/core/auctions/the_problem.md (3)
74-74: Uniform directional clearing prices clarification is correct.
The updated wording scopes uniform pricing to the same token pair and direction, and appropriately notes allowed deviations for extra gas costs.
87-87: Buy order scoring formula adjustment is accurate.
Multiplying by the limit price (π) now correctly reflects the intended scoring logic for buy orders, replacing the former division.
89-89: Fees specification note is accurate.
Clarifying that fees are denominated in the surplus token for both sell and buy orders enhances transparency and aligns with current protocol behavior.
Accidentally messed up @acanidio-econ PR (see here for the actual changes: 983c25b)
so i am reproposing the changes here.
Sorry about that
Summary by CodeRabbit