Add conditional download caching to LoadRuleGroups#7612
Open
PaurushGarg wants to merge 1 commit into
Open
Conversation
f7ab123 to
bfe4129
Compare
Signed-off-by: Paurush Garg <paurushg@amazon.com>
bfe4129 to
2866fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds conditional download caching to LoadRuleGroups() in the bucket rule store. Instead of downloading every rule group file from object storage on each sync cycle, it checks if the file has changed (via HEAD/Attributes) before doing a full GET.
Why:
The ruler syncs rule groups from object storage every poll interval (default 60s). For tenants with hundreds of rule groups, downloading all files every cycle is wasteful — most files don't change between syncs. The full GET + protobuf unmarshal for each file adds up, causing sync duration to approach or exceed the poll interval and trigger missed syncs.
Flow:
Observability:
New metric cortex_ruler_rule_group_load_cache_operations_total{result="hit|miss"} tracks cache effectiveness.
Testing:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags