feat: add Task.runtimeMetadata for host-resolved worker secrets#132
Open
NicholasDCole wants to merge 1 commit into
Open
feat: add Task.runtimeMetadata for host-resolved worker secrets#132NicholasDCole wants to merge 1 commit into
NicholasDCole wants to merge 1 commit into
Conversation
…types The server can resolve a worker's declared TaskDef.runtimeMetadata secret names at poll time and deliver the values on the wire-only Task.runtimeMetadata (conductor-oss PR #1255) — never persisted to task input. Declare the field on the Task schema so the generated client type carries it (string->string map, optional). The runtime client already keeps unknown JSON keys; this makes the field first-class and type-checked. - spec.json: Task.runtimeMetadata (object, additionalProperties string). - types.gen.ts: regenerated via `npm run generate-openapi-layer`. - __tests__/TaskRuntimeMetadata.test.ts: compile-time type guard (tsc) + JSON round-trip + omit-when-empty. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
runtimeMetadatato theTaskschema so the generated client type carries it.The server can resolve a worker's declared
TaskDef.runtimeMetadatasecret names at poll time and deliver the resolved values on the wire-onlyTask.runtimeMetadata(never persisted to task input). The runtime client already keeps unknown JSON keys; this makes the field first-class and type-checked.Changes
src/open-api/spec/spec.json:Task.runtimeMetadata(object,additionalProperties: { type: string }).src/open-api/generated/types.gen.ts: regenerated vianpm run generate-openapi-layer→runtimeMetadata?: { [key: string]: string }.src/open-api/__tests__/TaskRuntimeMetadata.test.ts: compile-time type guard + JSON round-trip + omit-when-empty.Test
npx jest --testMatch='**/src/open-api/__tests__/**/*.test.ts'passes; the type guard was validated fail-first withtsc(removing the field yieldsTS2339).🤖 Generated with Claude Code