Spring boot harness worker, metric meter registry flexibility, deprecate built-in webserver#125
Open
chrishagglund-ship-it wants to merge 5 commits into
Open
Spring boot harness worker, metric meter registry flexibility, deprecate built-in webserver#125chrishagglund-ship-it wants to merge 5 commits into
chrishagglund-ship-it wants to merge 5 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request type
Summary of Changes
Summary
Metrics are now published into a Micrometer
MeterRegistryand exposed by theembedding application, rather than by an SDK-owned web server.
conductor-client-metricsbinds aMetricsCollectorto the application'sMeterRegistry, and the client auto-configs auto-attach it to the client.SDK metrics show up on
/actuator/prometheuswith no wiring code.PrometheusMetricsCollector(MeterRegistry)constructor plusgetMeterRegistry(); exposeregistry.scrape()from an endpoint you own.via Actuator (
/metrics,/metrics-json,/health) instead of the SDK'sembedded server — demonstrating the recommended setup.
PrometheusMetricsCollector()andstartServer()still work for backwardcompatibility.
Compatibility
getRegistry()keeps its originalPrometheusMeterRegistryreturn type andis now deprecated in favor of
getMeterRegistry()(returns theMeterRegistryinterface, works for any registry type).ci.ymlgainschecks: write/pull-requests: writepermissions for test reporting.
Release: minor (
5.1.0→5.2.0) — additive features plus deprecations,no breaking changes; not a bugfix.