Add query parameters to workflow input#1227
Open
siva-sai-udaygiri wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the start workflow API so query parameters passed in the request URL are added to the workflow input.
Before this change, a request like:
POST /api/workflow?url_param=1234with body input:
{ "name": "test_workflow", "input": { "first": "xyz" } }would start the workflow with only the body input:
{ "first": "xyz" }Because of that,
${workflow.input.url_param}was not available during workflow execution.With this change, query parameters are merged into
StartWorkflowRequest.inputbefore the workflow is started, so the workflow input becomes:{ "first": "xyz", "url_param": "1234" }The implementation also handles cases where the request input is null by creating an input map before adding query parameters.
Added a unit test to verify that the controller passes the updated
StartWorkflowRequesttoWorkflowServicewith both the original body input and query parameter values included.