client: signal paid-download failure when the host can't invoice a chunk#775
Open
karamble wants to merge 1 commit into
Open
client: signal paid-download failure when the host can't invoice a chunk#775karamble wants to merge 1 commit into
karamble wants to merge 1 commit into
Conversation
When a getter requests a paid file chunk the host generates a per-chunk invoice; if that fails (e.g. dcrlnd has no inbound capacity), handleFTGetChunk returned the error without replying to the getter or notifying the host, so the host saw only a log line and the getter's download stalled forever. Mirror the tip-invoice path: fire OnInvoiceGenFailedNtfn on the host and reply to the getter using the existing RMFTPayForChunk.Error field. The getter now checks that field and raises a new OnFileDownloadFailed notification instead of trying to decode an empty invoice. Backwards compatible - the Error field already exists (omitempty); older peers ignore it. Adds a regression test that fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a getter requests a paid file chunk the host generates a per-chunk invoice; if that fails (e.g. dcrlnd has no inbound capacity), handleFTGetChunk returned the error without replying to the getter or notifying the host, so the host saw only a log line and the getter download stalled forever.
Mirror the tip-invoice path: fire OnInvoiceGenFailedNtfn on the host and reply to the getter using the existing RMFTPayForChunk.Error field. The getter now checks that field and raises a new OnFileDownloadFailed notification instead of trying to decode an empty invoice. Backwards compatible - the Error field already exists (omitempty); older peers ignore it.
Includes a regression test (TestFtPaidDownloadInvoiceGenFails) that times out without the fix.
Closes #774