Add IvanChalukov as approver to Concourse working group#1535
Conversation
|
As the promotion rule state we will require one additional approval (thumps up, +1 comment,...) from the Concourse WG approvals because we have four approvers in the area. One because we have already an approval from Taylor. Ping @yharish991, @Spimtav, @wayneadams, @ichandrabhatta. |
|
@drich10 can also approve. I believe he's out this week though. |
|
Approved! Yes I'm out but happened across this 👍 |
|
@taylorsilva, @drich10 we have all we need. The pr can be merged. You as working group leads should be able to merge. If not please let me know. |
|
@IvanChalukov After merging #1536 there are conflicts now. Could you please resolve the conflicts so that I can merge. |
|
@beyhan I've resolved the conflicts and removed the reviewers section, as there are no reviewers remaining. Please let me know if this is sufficient. |
|
I'm merging as the Concourse WG is not yet onboarded into the CF org automation and the leads aren't able to merge yet. |
|
@IvanChalukov FYI we need to sort out the automation stuff still, but for now I'll manually add you to the existing team that the other approvers are on. |
Concourse: Core Contributions
PRs Commented on/Reviewed:
CONCOURSE_VAULT_ENABLE_KV_MOUNT_CACHE)Issues that may be relevant:
build_resource_config_version_inputstable never clean upCode contributions: