refactor(wallet-sdk): allow wallet SDK plugins to use namespaces, simplify plugin registration#2099
Open
mateuszpiatkowski-da wants to merge 1 commit into
Conversation
…space in plugin class Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Contributor
Author
|
@fayi-da @rukmini-basu-da please let me know your thoughts if you have a moment to spare :) Thank you! |
fayi-da
reviewed
Jul 9, 2026
Comment on lines
-171
to
+173
| public registerPlugins< | ||
| P extends Record<string, new (ctx: SDKContext) => SDKPlugin>, | ||
| >(plugins: P): SDKInterface<CurrentlyExtended> & RegisteredPlugins<P> { | ||
| public registerPlugins<P extends PluginConstructor[]>( | ||
| plugins: P | ||
| ): SDKInterface<CurrentlyExtended> & RegisteredPlugins<P> { |
Contributor
Author
There was a problem hiding this comment.
hmm didn't think of it this way. The change of interface might be breaking 🤔 in this case I think I'm gonna put it on hold until we release another version? WDYT? @fayi-da
fayi-da
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.