fix: addSession verify that token matches network#2096
Open
pawelstepien-da wants to merge 10 commits into
Open
fix: addSession verify that token matches network#2096pawelstepien-da wants to merge 10 commits into
pawelstepien-da wants to merge 10 commits into
Conversation
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…t networks Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…dsession-verify-token Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
pawelstepien-da
commented
Jul 9, 2026
| .then(() => { | ||
| redirectToIntendedOrDefault() | ||
| }) | ||
| .catch(handleErrorToast) |
Contributor
Author
There was a problem hiding this comment.
Potentially we could also call stateManager.clearAuthState and redirect to login, but that would clear the error toast from HTML before user can see it, additional workaround would be needed. Open for discussion how to handle it UX-wise.
That situation happens when there are issues with accessToken that make addSession fail. Before it just stayed at this page forever displaying "Logged in!", with my change it at least indicates that there was some error.
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
…dsession-verify-token Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
userApi.addSessionadd verification that accessToken claimsiss,aud,sub,scpandscopematch their counterparts in auth of the network passed as argument.Adjust mock-oauth2 hardcoded
scpandscopeclaims to match values defined in WG config default networks.In login-callback if addSession fails show error toast.