Expose EmptyFileError and ReachMaximumTriesError in the public API#351
Open
elvis-aguero wants to merge 1 commit into
Open
Expose EmptyFileError and ReachMaximumTriesError in the public API#351elvis-aguero wants to merge 1 commit into
elvis-aguero wants to merge 1 commit into
Conversation
These two exceptions are raised by public methods (ExperimentData.from_file and the domain/data loading paths) but are only importable from f3dasm._src.errors. Callers cannot catch what the public API throws without reaching into the private _src module. Re-export them at the top level, matching how the other user-facing classes are exposed. Re-export only, no behavior change.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes two exceptions that are raised from user-facing code paths importable from the top-level f3dasm package, so downstream users can catch them without importing from the private f3dasm._src package.
Changes:
- Re-export
EmptyFileErrorandReachMaximumTriesErrorfromf3dasm.__init__. - Add both symbols to
__all__so wildcard imports include them.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmptyFileErrorandReachMaximumTriesErrorare raised by public methods(
ExperimentData.from_fileand the domain/data loading paths), but they canonly be imported from
f3dasm._src.errors. Code that uses the public APIcannot catch what that API throws without reaching into the private
_srcmodule.
This re-exports both at the top level, the same way the other user-facing
classes are exposed:
Re-export only. No behavior change and no new dependencies.