feat(campaign): add getCampaignClaimers method and related tests for pagination and validation#1462
Open
harryburger wants to merge 1 commit into
Open
feat(campaign): add getCampaignClaimers method and related tests for pagination and validation#1462harryburger wants to merge 1 commit into
harryburger wants to merge 1 commit into
Conversation
…pagination and validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This pull request adds a new API endpoint to retrieve the list of claimers for a campaign, including detailed claim information, and introduces all supporting model, controller, schema, and test logic. The endpoint supports pagination and returns metadata along with claimer details such as address, claimed amount, and transaction information.
New Campaign Claimers Endpoint
API and Routing:
/campaign/claimersto the CapitalDistributor router, with OpenAPI-style documentation and pagination support. The endpoint returns a paginated list of addresses that claimed a campaign reward, including claim details.Controller Logic:
getCampaignClaimersinCapitalDistributorControllerto validate parameters, check campaign existence, and delegate to the model for data retrieval.CapitalDistributorSchema.Model and Types:
getCampaignClaimersstatic method toCampaignRewardmodel, which aggregates and paginates claimer data, flattening claim information for each user.ICampaignClaimertype to define the returned claimer structure.Testing
Unit Tests:
✅ Checklist
🔍 Code Review
🧪 Testing
🔒 Security