Skip to content

Add defaults to ViewVersion fields#3458

Merged
Fokko merged 2 commits into
apache:mainfrom
ebyhr:ebi/view-default
Jun 9, 2026
Merged

Add defaults to ViewVersion fields#3458
Fokko merged 2 commits into
apache:mainfrom
ebyhr:ebi/view-default

Conversation

@ebyhr

@ebyhr ebyhr commented Jun 5, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Allow users to create a view with fewer parameters.

We can set an environment context (engine-name and engine-version) in summary field by default
once #3441 is merged.

Are these changes tested?

Yes

Are there any user-facing changes?

No

Comment thread tests/catalog/test_rest.py
Comment thread tests/catalog/test_rest.py
Comment thread pyiceberg/view/metadata.py Outdated
Comment thread pyiceberg/view/metadata.py Outdated
@ebyhr

ebyhr commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

Thanks for your review! Addressed comments.

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ebyhr

@Fokko Fokko merged commit ec1413d into apache:main Jun 9, 2026
16 checks passed
@Fokko

Fokko commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Merging since @rambleraptor already approved, thanks for the review 🙌

@ebyhr ebyhr deleted the ebi/view-default branch June 10, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants