Conversation
6 tasks
4baa37e to
8a0fd6a
Compare
a nicer way to load the package.json to get pkg.name & pkg.version simplify Nano a bit. Removed some old code and made "relax" a simpler function. At the same time, i have made the ...AsStream functions "async" as they were a bit odd in that regard, returning synchronously. added test coverage output and ensure 100% test coverage of lib/nano.js findAsStream returns a Promise which resolves as a stream fix basicauth test fix basic auth test rename .js to .mjs added CSM & EJS build steps
show breaking changes in Nano 12 at the top of the readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Preparation work for Nano 12.
..AsStreamvariants of the functions are now "async" - i.e. they return a Promise which resolves to a stream, rather than synchronously returning a dummy stream as before. This makes the code easier to maintain, but is a breaking change.rolldownto build CommonJS and ESM variants of the code. Themodule&mainkeys inpackage.jsonmake it such that the package "just works" for both CJS and ESM code.prepublishOnlyscript to ensure that the transpiled artifacts are generated during annpm publishevent, but are gitignored from the repo.Testing recommendations
All the tests have changed in the require-->import sense, but are functionally identical.
Checklist