fix out-of-bounds read in antlr3UTF8LA backward traversal#236
Open
zayeem06 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
antlr3UTF8LA walks backwards over UTF-8 continuation bytes to find the start of a code point when asked for a negative lookahead, but the inner skip loop had no lower bound. On input that begins with continuation bytes (malformed UTF-8), a consume followed by LA(-1) steps the pointer before input->data and reads input->data[-1], a heap buffer under-read that AddressSanitizer flags at the skip loop. Bounded the scan with nextChar > input->data so it stops at the start of the buffer; well-formed input is unaffected because the first byte of the buffer is never a continuation byte.