Skip to content

Use only endpoint for sendMessage and makeCall#22

Open
corinac123 wants to merge 5 commits into
android:mainfrom
corinac123:use-endpoint-only
Open

Use only endpoint for sendMessage and makeCall#22
corinac123 wants to merge 5 commits into
android:mainfrom
corinac123:use-endpoint-only

Conversation

@corinac123

Copy link
Copy Markdown
Contributor

Use only endpoint for sendMessage and makeCall, because this is enough to uniquely identify a contact / group.

* Add an endpoint for Bob

* Repository returns all recipients with same name

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the app functions by removing the name parameter from the send function and the contactName parameter from the makeCall function, making both functions rely solely on unique identifiers (endpointValue). Corresponding tests, metadata, and fallback lookup logic in CallManager and ChatViewModel have been updated. Feedback is provided regarding the duplication of the CallManager class between the app and shared modules, and a suggestion is made to support group calls in makeCall by checking for groups when a recipient is not found by ID.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ChatApp/app/src/main/kotlin/com/example/chatapp/data/CallManager.kt
@corinac123 corinac123 requested a review from keyboardsurfer July 2, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant