Skip to content

Add an endpoint for Bob#20

Merged
keyboardsurfer merged 2 commits into
android:mainfrom
corinac123:add-endpoint-to-bob
Jul 2, 2026
Merged

Add an endpoint for Bob#20
keyboardsurfer merged 2 commits into
android:mainfrom
corinac123:add-endpoint-to-bob

Conversation

@corinac123

Copy link
Copy Markdown
Contributor

Add a second endpoint for contact Bob to ensure this scenario is supported.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new recipient named "Bob Johnson" to the list of recipients in both the app and shared RecipientsRepository files. The review comments identify a critical issue where adding a duplicate name "Bob Johnson" will cause getRecipientByName to throw an IllegalArgumentException at runtime due to its use of singleOrNull. It is recommended to update getRecipientByName to use firstOrNull or return a list of matching recipients to prevent this crash.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@keyboardsurfer keyboardsurfer merged commit 8b4cc0e into android:main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants