feat(landing): add /health liveness endpoint (convention)#28
Merged
Conversation
The container HEALTHCHECK probed '/' (HTML, no provenance). Add a /health route
matching backend/memory-mcp/auth/dashboard/sync: { success, data: { status,
service, commit, buildTime } } with force-dynamic runtime env, and point the
Dockerfile HEALTHCHECK at it.
|
✅ CI - Verify PASSED Commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Landing was the only agentage service without a
/healthendpoint — its container HEALTHCHECK probed/(HTML, no build provenance). Add a/healthroute following the shared convention and repoint the healthcheck.Convention
{ "success": true, "data": { "status": "ok", "service": "landing", "commit": "…", "buildTime": "…" } }Matches backend (
/api/health), memory-mcp, auth, dashboard, sync.Changes
packages/landing/src/app/health/route.ts—GETreturns the envelope;force-dynamicsocommit/buildTimecome from the running container env; Next servesHEADfrom it. No auth middleware in landing, so it's public by default.Dockerfile— HEALTHCHECK/→/health.Verified (runtime, landing dev)
GET /health→{"success":true,"data":{"status":"ok","service":"landing","commit":"landabc99","buildTime":"…"}}.HEAD /health→ 200;/still serves the site (200). Type-check + lint clean.Part of fleet-wide health alignment (web#390 = dashboard + sync; mcp-catalog PR separate).