Tests: Cover page-cache-aware default eagerness in wp_get_speculation_rules_configuration()#12308
Conversation
…_rules_configuration(). Adds unit tests for the dynamic conservative-to-moderate default eagerness promotion gated by persistent object cache + a detected page cache, as proposed in https://core.trac.wordpress.org/ticket/64066. The new tests cover: * All four combinations of {object cache present, absent} x {advanced_cache_present, caching_response_headers, neither, both}. * Non-production environments (local, development, staging) keeping the default at conservative even when a page cache has been detected. * A missing page-cache detail transient not promoting the default. * A non-array transient value (corrupt option) not emitting warnings and not promoting the default. * An explicit plugin filter value being respected even when the auto promotion would otherwise apply, ensuring plugins retain control over the configured eagerness. set_up() and tear_down() isolate WP_ENVIRONMENT_TYPE, wp_using_ext_object_cache(), and the health_check_page_cache_detail transient between tests. These tests are expected to fail against trunk until WordPress#10123 is merged; they all pass when the speculative-loading.php and class-wp-site-health.php changes from that PR are applied.
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
https://core.trac.wordpress.org/ticket/64066
Adds PHPUnit coverage for the dynamic
conservative→moderatedefault eagerness promotion gated by persistent object cache and a detected page cache.These tests are expected to fail against trunk until #10123 is merged; they pass when the
speculative-loading.phpandclass-wp-site-health.phpchanges from that PR are applied.